hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14730) hasAcl property always set to false, regardless of FsPermission higher bit order
Date Mon, 07 Aug 2017 21:20:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117323#comment-16117323
] 

Chris Douglas commented on HADOOP-14730:
----------------------------------------

bq. Verified v004 did work in this use case: 3.0.0b1 hadoop-azure-datalake jar dropped into
a 2.9.0 cluster. However, is the use case supported? Is the maintenance cost over benefit?
Thanks for testing this, John. I'll fix the other issues and upload a new patch.

bq. The inheritance of AdlFileStatus from FileStatus introduces tight coupling between these
2 classes, although AdlFileStatus is pretty simple at this point.
It's hard to do better, unfortunately. Particularly since we deprecated, but still support
the {{Writable}} behavior in 3.x.

bq. However, if it's easy to support and useful, we might as well.
If it's linked against a 2.x client, this will drop the {{hasAcl}} field using {{Writable}}
serialization. That... may be fixable, but {{FsPermissionExtension}} looks like it discards
it, anyway. I'd ignore this case.

Maintaining this kind of backward-compatibility is ultimately not viable, but we can sustain
the complexity added by v004. I'll fix the issues [~jzhuge] pointed out and we can wrap this
up.

> hasAcl property always set to false, regardless of FsPermission higher bit order 
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-14730
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14730
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0-beta1
>            Reporter: Vishwajeet Dusane
>            Assignee: Chris Douglas
>             Fix For: 3.0.0-beta1
>
>         Attachments: HADOOP-14730.001.patch, HADOOP-14730.002.patch, HADOOP-14730.003.patch,
HADOOP-14730.004.patch
>
>
> 2 Unit Test cases are failing  [Azure-data-lake Module |https://github.com/apache/hadoop/blob/4966a6e26e45d7dc36e0b270066ff7c87bcd00cc/hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/TestGetFileStatus.java#L44-L44],
caused after HDFS-6984 commit.
> Issue seems to be {{hasAcl}} is hard coded to {{false}}. 
> {code:java}
> public FileStatus(long length, boolean isdir,
>                     int block_replication,
>                     long blocksize, long modification_time, long access_time,
>                     FsPermission permission, String owner, String group, 
>                     Path symlink,
>                     Path path) {
>     this(length, isdir, block_replication, blocksize, modification_time,
>         access_time, permission, owner, group, symlink, path,
>         false, false, false);
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message