hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14726) Remove FileStatus#isDir
Date Thu, 03 Aug 2017 20:23:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113415#comment-16113415

Chris Douglas commented on HADOOP-14726:

bq.  I think it's too late to remove at this point in the release cycle; if we're serious
about doing this for Hadoop 4, then let's file JIRAs for these downstreams to switch over.
Hrm; seems like it's too late to remove this, ever. So it goes.

bq. It is still incompatible though, since marking isDir final breaks out-of-tree FileSystems
that override it. Is this necessary?
It's not necessary, it's the most aggressive variant we could push in Hadoop 3. I could make
something up about JIT efficiency when {{isDir}} is final, but the only real argument in favor
is to make sure FileSystem implementors override these two calls consistently. It's a corner
of a corner case, either way.

> Remove FileStatus#isDir
> -----------------------
>                 Key: HADOOP-14726
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14726
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: fs
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: HADOOP-14726.000.patch
> FileStatus#isDir was deprecated in 0.21 (HADOOP-6585).

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message