hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14706) Adding a helper method to determine whether a log is Log4j implement
Date Wed, 02 Aug 2017 05:52:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110356#comment-16110356
] 

Akira Ajisaka commented on HADOOP-14706:
----------------------------------------

Thank you [~vincent he] for creating the patch.
I prefer GenericsUtil rather than LogAdapter. LogAdapter has some instance variables and non-static
methods, so it's not good to add a static helper method there.

> Adding a helper method to determine whether a log is Log4j implement
> --------------------------------------------------------------------
>
>                 Key: HADOOP-14706
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14706
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: util
>            Reporter: Wenxin He
>            Assignee: Wenxin He
>            Priority: Minor
>         Attachments: HADOOP-14706.001.patch
>
>
> Base on the comments in YARN-6873, we'd like to add a helper method to determine whether
a log is Log4j implement.
> Using this helper method, we don't have to care about it's org.apache.commons.logging
or org.slf4j.Logger used in our system.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message