hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14669) GenericTestUtils.waitFor should use monotonic time
Date Tue, 01 Aug 2017 18:21:01 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109455#comment-16109455
] 

Jason Lowe commented on HADOOP-14669:
-------------------------------------

I suspect there's more than test code that is using the wrong clock.  Filed HADOOP-14713 for
tracking the task of auditing the code for cases that need to be fixed.  We can link the relevant
subtask JIRAs there.

> GenericTestUtils.waitFor should use monotonic time
> --------------------------------------------------
>
>                 Key: HADOOP-14669
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14669
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Jason Lowe
>            Assignee: Daniel Templeton
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 2.9.0, 3.0.0-beta1
>
>         Attachments: HADOOP-14669.001.patch, HADOOP-14669.002.patch, HADOOP-14669.003.patch
>
>
> GenericTestUtils.waitFor should be calling Time.monotonicNow rather than Time.now.  Otherwise
if the system clock adjusts during unit testing the timeout period could be incorrect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message