hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinayakumar B (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-14439) regression: secret stripping from S3x URIs breaks some downstream code
Date Wed, 02 Aug 2017 13:00:14 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vinayakumar B updated HADOOP-14439:
-----------------------------------
    Attachment: HADOOP-14439-01.patch

Re-adding the secret to S3X urI in the same secret encoded format.

Following are the highlights of changes:

1. Builds the FSUri containing only schema and authority part.
2. Strips down secret part if {{user}} was not provided in the {{userinfo}} section.
3. Encodes the secret part, even if original passed uri was not containing encoded secret.

So, direct comparison of fs uri and provided uri still might fail in above cases.

Please review.

> regression: secret stripping from S3x URIs breaks some downstream code
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-14439
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14439
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 2.8.0
>         Environment: Spark 2.1
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-14439-01.patch
>
>
> Surfaced in SPARK-20799
> Spark is listing the contents of a path with getFileStatus(path), then looking up the
path value doing a lookup of the contents.
> Apparently the lookup is failing to find files if you have a secret in the key, {{s3a://key:secret@bucket/path}}.

> Presumably this is because the stripped values aren't matching.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message