Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 8 Jul 2017 04:43:01 +0000 (UTC)
From: "Mingliang Liu (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13085522.1499438481000.198523.1499488981156@Atlassian.JIRA>
In-Reply-To: <JIRA.13085522.1499438481000@Atlassian.JIRA>
References: <JIRA.13085522.1499438481000@Atlassian.JIRA> <JIRA.13085522.1499438481971@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HADOOP-14631) Distcp should add a default
  atomicWorkPath properties when using atomic or throw obvious Exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 08 Jul 2017 04:43:14 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-14631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078952#comment-16078952 ] 

Mingliang Liu commented on HADOOP-14631:
----------------------------------------

Hi [~Hongyuan Li], thanks for filing this. I'd suggest we use a default workPath in case it's not set. NPE currently definitely is bad.

> Distcp should add a default  atomicWorkPath properties when using atomic or throw obvious Exception
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14631
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14631
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.7.3, 3.0.0-alpha3
>            Reporter: Hongyuan Li
>            Assignee: Hongyuan Li
>
> Distcp should add a default  AtomicWorkPath properties when using atomic
> {{Distcp}}#{{configureOutputFormat}} using code below to generate atomic work path,
> {code}
>     if (context.shouldAtomicCommit()) {
>       Path workDir = context.getAtomicWorkPath();
>       if (workDir == null) {
>         workDir = targetPath.getParent();
>       }
>       workDir = new Path(workDir, WIP_PREFIX + targetPath.getName()
>                                 + rand.nextInt());
> {code}
> When atomic is set and {{AtomicWorkPath}} == null, distcp will get the parent of current {{WorkDir}}. In this case, if {{workdir}} is {{"/"}}, the parent will be {{null}}, wich means 
> {{workDir = new Path(workDir, WIP_PREFIX + targetPath.getName() + rand.nextInt());}} will throw a nullpoint exception.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org