Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C7516200CCF for ; Mon, 10 Jul 2017 06:36:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C589B1678AC; Mon, 10 Jul 2017 04:36:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1F170167890 for ; Mon, 10 Jul 2017 06:36:04 +0200 (CEST) Received: (qmail 39418 invoked by uid 500); 10 Jul 2017 04:36:04 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 39407 invoked by uid 99); 10 Jul 2017 04:36:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jul 2017 04:36:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 989F51916ED for ; Mon, 10 Jul 2017 04:36:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 83z267Y6K5x7 for ; Mon, 10 Jul 2017 04:36:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7DD49625FB for ; Mon, 10 Jul 2017 04:36:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A22B0E0984 for ; Mon, 10 Jul 2017 04:36:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 22C4A24698 for ; Mon, 10 Jul 2017 04:36:00 +0000 (UTC) Date: Mon, 10 Jul 2017 04:36:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 10 Jul 2017 04:36:05 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079856#comment-16079856 ] ASF GitHub Bot commented on HADOOP-14539: ----------------------------------------- Github user aajisaka commented on a diff in the pull request: https://github.com/apache/hadoop/pull/246#discussion_r126333782 --- Diff: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SecurityUtil.java --- @@ -53,6 +51,8 @@ //this will need to be replaced someday when there is a suitable replacement +import org.slf4j.Logger; --- End diff -- Would you move the new imports above the comment "this will need to ...."? > Move commons logging APIs over to slf4j in hadoop-common > -------------------------------------------------------- > > Key: HADOOP-14539 > URL: https://issues.apache.org/jira/browse/HADOOP-14539 > Project: Hadoop Common > Issue Type: Sub-task > Reporter: Akira Ajisaka > Assignee: Wenxin He > -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org