Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C5037200CD0 for ; Tue, 11 Jul 2017 02:48:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C352C164BF2; Tue, 11 Jul 2017 00:48:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 15885164BED for ; Tue, 11 Jul 2017 02:48:02 +0200 (CEST) Received: (qmail 83941 invoked by uid 500); 11 Jul 2017 00:48:02 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 83930 invoked by uid 99); 11 Jul 2017 00:48:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jul 2017 00:48:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A8540194D95 for ; Tue, 11 Jul 2017 00:48:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id pzKkhxT0i_Zh for ; Tue, 11 Jul 2017 00:48:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D29D362778 for ; Tue, 11 Jul 2017 00:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6B9EDE0732 for ; Tue, 11 Jul 2017 00:48:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1111A246A0 for ; Tue, 11 Jul 2017 00:48:00 +0000 (UTC) Date: Tue, 11 Jul 2017 00:48:00 +0000 (UTC) From: "Jitendra Nath Pandey (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10829) Iteration on CredentialProviderFactory.serviceLoader is thread-unsafe MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 11 Jul 2017 00:48:04 -0000 [ https://issues.apache.org/jira/browse/HADOOP-10829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081440#comment-16081440 ] Jitendra Nath Pandey commented on HADOOP-10829: ----------------------------------------------- I will commit this shortly. > Iteration on CredentialProviderFactory.serviceLoader is thread-unsafe > ---------------------------------------------------------------------- > > Key: HADOOP-10829 > URL: https://issues.apache.org/jira/browse/HADOOP-10829 > Project: Hadoop Common > Issue Type: Bug > Components: security > Affects Versions: 2.6.0 > Reporter: Benoy Antony > Assignee: Benoy Antony > Labels: BB2015-05-TBR > Attachments: HADOOP-10829.003.patch, HADOOP-10829.patch, HADOOP-10829.patch > > > CredentialProviderFactory uses _ServiceLoader_ framework to load _CredentialProviderFactory_ > {code} > private static final ServiceLoader serviceLoader = > ServiceLoader.load(CredentialProviderFactory.class); > {code} > The _ServiceLoader_ framework does lazy initialization of services which makes it thread unsafe. If accessed from multiple threads, it is better to synchronize the access. > Similar synchronization has been done while loading compression codec providers via HADOOP-8406. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org