hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14681) Remove MockitoMaker class
Date Tue, 25 Jul 2017 08:58:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099732#comment-16099732
] 

Hudson commented on HADOOP-14681:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12052 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12052/])
HADOOP-14681. Remove MockitoMaker class. Contributed by Andras Bokor. (aajisaka: rev cca51e916b7387ea358688e8f8188ead948fbdcc)
* (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestMRCJCFileInputFormat.java
* (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestDiskChecker.java
* (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/metrics/TestMRAppMetrics.java
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestQueueMetrics.java
* (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/test/java/org/apache/hadoop/mapred/TestShuffleHandler.java
* (delete) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/MockitoMaker.java


> Remove MockitoMaker class
> -------------------------
>
>                 Key: HADOOP-14681
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14681
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>             Fix For: 2.9.0, 3.0.0-beta1
>
>         Attachments: HADOOP-14681.01.patch
>
>
> I would remove MockitoMaker class and use the standard way to mock objects.
> For developers it's harder to read and misleading since it's using the deprecated syntax.
> In addition, it is only used at only some places so we using Mockito on a not-unified
way. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message