hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14659) UGI getShortUserName does not need to search the Subject
Date Fri, 14 Jul 2017 02:11:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086732#comment-16086732
] 

Aaron Fabbri commented on HADOOP-14659:
---------------------------------------

+1 (non-binding) looks correct to me.  I assume you're going to commit to trunk and backport?

> UGI getShortUserName does not need to search the Subject
> --------------------------------------------------------
>
>                 Key: HADOOP-14659
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14659
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 2.0.0-alpha
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-14659.patch
>
>
> {{UGI#getShortUserName}} searches the subject for the {{User}} instance.  It's not cheap
to iterate a synchronized set, copy matches into a new set, then iterating that set.  The
UGI ctor already set the {{User}} into a final field...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message