hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14638) Replace commons-logging APIs with slf4j in StreamPumper
Date Mon, 10 Jul 2017 06:57:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079943#comment-16079943
] 

Akira Ajisaka commented on HADOOP-14638:
----------------------------------------

Would you fix the following checkstyle issue?
{noformat}
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestShellCommandFencer.java:195:
   private static final List<String> delegateMethods = Lists.asList("error",:39: Name
'delegateMethods' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
{noformat}
I think we can ignore the following issue:
{noformat}
./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ShellCommandFencer.java:64:
 static Logger LOG = LoggerFactory.getLogger(ShellCommandFencer.class);:17: Name 'LOG' must
match pattern '^[a-z][a-zA-Z0-9]*$'. [StaticVariableName]
{noformat}
I'm +1 if that is addressed. Thanks!

> Replace commons-logging APIs with slf4j in StreamPumper
> -------------------------------------------------------
>
>                 Key: HADOOP-14638
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14638
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Wenxin He
>            Assignee: Wenxin He
>         Attachments: HADOOP-14638.001.patch
>
>
> HADOOP-14539 is big, so we split a separate issue from HADOOP-14539.
> Now StreamPumper only accepts commons-logging logger API, so we should change StreamPumper
api to accept slf4j and change the related code including some tests in TestShellCommandFencer
that failed with slf4j.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message