hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hongyuan Li (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-14631) Distcp should add a default AtomicWorkPath properties when using atomic
Date Fri, 07 Jul 2017 14:45:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hongyuan Li updated HADOOP-14631:
---------------------------------
    Description: 
Distcp should add a default  AtomicWorkPath properties when using atomic

{{Distcp}}#{{configureOutputFormat}} using code below to generate atomic work path

{code}
    if (context.shouldAtomicCommit()) {
      Path workDir = context.getAtomicWorkPath();
      if (workDir == null) {
        workDir = targetPath.getParent();
      }
      workDir = new Path(workDir, WIP_PREFIX + targetPath.getName()
                                + rand.nextInt());
[code}

When atomic is set and {{AtomicWorkPath}} == null, distcp will get the parent of current {{WorkDir}}.
In this case, if {{workdir}} is {{"/"}}, the parent will be {{null}}, wich means 
{{workDir = new Path(workDir, WIP_PREFIX + targetPath.getName() + rand.nextInt());}} will
throw a nullpoint exception.

  was:
Distcp should add a default  AtomicWorkPath properties when using atomic

{{Distcp}}#{{configureOutputFormat}} using code below to generate atomic work path

{code}
    if (context.shouldAtomicCommit()) {
      Path workDir = context.getAtomicWorkPath();
      if (workDir == null) {
        workDir = targetPath.getParent();
      }
      workDir = new Path(workDir, WIP_PREFIX + targetPath.getName()
                                + rand.nextInt());
[code}

When atomic is set and tAtomicWorkPath == null, distcp will get the parent of current WorkDir.
In this case, if {{workdir}} is {{"/"}}, the parent will be {{null}}, wich means 
{{ workDir = new Path(workDir, WIP_PREFIX + targetPath.getName() + rand.nextInt());}} will
throw a nullpoint exception.


> Distcp should add a default  AtomicWorkPath properties when using atomic
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-14631
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14631
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Hongyuan Li
>
> Distcp should add a default  AtomicWorkPath properties when using atomic
> {{Distcp}}#{{configureOutputFormat}} using code below to generate atomic work path
> {code}
>     if (context.shouldAtomicCommit()) {
>       Path workDir = context.getAtomicWorkPath();
>       if (workDir == null) {
>         workDir = targetPath.getParent();
>       }
>       workDir = new Path(workDir, WIP_PREFIX + targetPath.getName()
>                                 + rand.nextInt());
> [code}
> When atomic is set and {{AtomicWorkPath}} == null, distcp will get the parent of current
{{WorkDir}}. In this case, if {{workdir}} is {{"/"}}, the parent will be {{null}}, wich means

> {{workDir = new Path(workDir, WIP_PREFIX + targetPath.getName() + rand.nextInt());}}
will throw a nullpoint exception.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message