hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hongyuan Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14623) fixed some bugs in KafkaSink
Date Tue, 25 Jul 2017 08:23:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099702#comment-16099702
] 

Hongyuan Li commented on HADOOP-14623:
--------------------------------------

Hi, [~bharatviswa], you are right. It does not matter. The value of param {{key.serializer}}
 in the origin code is {{ByteArraySerializer}}, which is not the correct corespondent  serializer
class of type Integer, so i changed the type to {{byte[]}} although the key has not been used.
If this would confuse you, i will remove the modification and resubmit a new patch.

Thanks anyway for your code review.

> fixed some bugs in KafkaSink 
> -----------------------------
>
>                 Key: HADOOP-14623
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14623
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common, tools
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Hongyuan Li
>            Assignee: Hongyuan Li
>         Attachments: HADOOP-14623-001.patch, HADOOP-14623-002.patch, HADOOP-14623-003.patch,
HADOOP-14623-004.patch
>
>
> {{KafkaSink}}#{{init}}  should set ack to *1* to make sure the message has been written
to the broker at least.
> current code list below:
> {code}
>   
>     props.put("request.required.acks", "0");
> {code}
> *Update*
> find another bug about this class, {{key.serializer}} used {{org.apache.kafka.common.serialization.ByteArraySerializer}},
however, the key properties of Producer is Integer, codes list below:
> {code}
>     props.put("key.serializer",
>         "org.apache.kafka.common.serialization.ByteArraySerializer");
> ……………
>  producer = new KafkaProducer<Integer, byte[]>(props);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message