hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14587) Use GenericTestUtils.setLogLevel when available in hadoop-common
Date Tue, 04 Jul 2017 10:15:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073431#comment-16073431

Akira Ajisaka commented on HADOOP-14587:

Thank you for updating the patch. Mostly looks good to me.
Would you replace {{GenericTestUtils.setLogLevel(getLogger("org"), Level.DEBUG)}} with {{GenericTestUtils.setRootLogLevel}}
in TestGroupFallback.java? I'm +1 if that is addressed.

> Use GenericTestUtils.setLogLevel when available in hadoop-common
> ----------------------------------------------------------------
>                 Key: HADOOP-14587
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14587
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Wenxin He
>            Assignee: Wenxin He
>         Attachments: HADOOP-14587.001.patch, HADOOP-14587.002.patch, HADOOP-14587.003.patch,
> Based on Brahma's comment in HADOOP-14296, it's better to use GenericTestUtils.setLogLevel
as possible to make the migration easier.
> Based on Akira Ajisaka's comment in HADOOP-14549, create a separate jira for hadoop-common

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message