hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wenxin He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14539) Move commons logging APIs over to slf4j in hadoop-common
Date Fri, 07 Jul 2017 09:27:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077857#comment-16077857
] 

Wenxin He commented on HADOOP-14539:
------------------------------------

Since the change is big, it's divided into several commit steps:

*Step 1*: (521ac19f9226ea271c239b9b7345d64d82ab35d4) 
simply replace all {{org.apache.commons.logging.Log}} to {{org.slf4j.Logger}} where available.

*Step 2*: (a86f2b25202808f1e4ef2b6ce214f63dfa75e967)
change {{org.apache.commons.logging.LOG.fatal()}} to {{org.slf4j.LoggerLOG.error()}} for api
incompatibility.

*Step 3*: (fa9af169900f3515e65814ef7ca1c98914e90715)
change {{org.apache.commons.logging.Log.debug(Object)}} to {{org.slf4j.Logger.debug(String)}}
for api incompatibility.

*Step 4*: (7af274b3e89da963691272335256004ebf9f1b83)
handle a special case in DelegationTokenRenewer: change {{LOG.debug(ie.getStackTrace())}}
to {{LOG.debug("Exception in removeRenewAction: ", ie)}}

*Step 5*: (7af274b3e89da963691272335256004ebf9f1b83)
handle a special case in AbstractService: change {{LOG.debug("noteFailure " + exception, null)}}
to {{LOG.debug("noteFailure " + exception, (Throwable) null)}}

*Step 6*: (4ce2b824e77590407f77f326f16c39175aceccbf)
change {{IOUtils.cleanup}} to {{IOUtils.cleanupWithLogger}}

*Step 7*: (d82797fb88dbea12ffa0db926b894cc9123e444f)
revert {{FileSystem.LOG}} for it's referenced by hadoop-yarn

*Step 8*: (f0ffa503fb135d84e542ecea80cb3d6224983cd3)
change {{SignalLogger.INSTANCE.register(LOG)}} to {{SignalLogger.INSTANCE.register(LogAdapter.create(LOG))}}



> Move commons logging APIs over to slf4j in hadoop-common
> --------------------------------------------------------
>
>                 Key: HADOOP-14539
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14539
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Akira Ajisaka
>            Assignee: Akira Ajisaka
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message