hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hongyuan Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14470) CommandWithDestination#create used redundant ternary operator
Date Mon, 03 Jul 2017 12:19:01 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072329#comment-16072329
] 

Hongyuan Li commented on HADOOP-14470:
--------------------------------------

seems this has been rsolved. Should this be closed? [~stevel@apache.org] 

> CommandWithDestination#create used redundant ternary operator  
> ---------------------------------------------------------------
>
>                 Key: HADOOP-14470
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14470
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common, fs
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Hongyuan Li
>            Assignee: Hongyuan Li
>            Priority: Trivial
>         Attachments: HADOOP-14470-001.patch
>
>
> in if statement,the lazyPersist  is always true, thus the ternary operator is redundant,
> {{lazyPersist == true}} in if statment, so {{lazyPersist ? 1 : getDefaultReplication(item.path)}}
is redundant.
>   related code like below, which is in {{org.apache.hadoop.fs.shell.CommandWithDestination}}
 lineNumber : 504 :
> {code:java}
>    FSDataOutputStream create(PathData item, boolean lazyPersist,
>         boolean direct)
>         throws IOException {
>       try {
>         if (lazyPersist) { // in if stament, lazyPersist is always true
>       ……
>           return create(item.path,
>                         FsPermission.getFileDefault().applyUMask(
>                             FsPermission.getUMask(getConf())),
>                         createFlags,
>                         getConf().getInt(IO_FILE_BUFFER_SIZE_KEY,
>                             IO_FILE_BUFFER_SIZE_DEFAULT),
>                         lazyPersist ? 1 : getDefaultReplication(item.path), // *this
is redundant*
>                         getDefaultBlockSize(),
>                         null,
>                         null);
>         } else {
>           return create(item.path, true);
>         }
>       } finally { // might have been created but stream was interrupted
>         if (!direct) {
>           deleteOnExit(item.path);
>         }
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message