hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manoj Govindassamy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14396) Add builder interface to FileContext
Date Tue, 18 Jul 2017 02:12:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090990#comment-16090990
] 

Manoj Govindassamy commented on HADOOP-14396:
---------------------------------------------

Looks good overall, [~eddyxu]. +1 with few comments:

1. {{FSDataOutputStreamBuilder}} line 79: fs = null when built from file context. Later in
getFS() there is Preconditions.checkNotNull(fs); So, the expectation is no one should be calling
getFS() when it is constructed from FileContext ?

2. {{FileContext.java}} 
-- +import org.apache.zookeeper.Op; can be removed
-- line 704: There is an annotation {{@Nonnull FileContext fc}} and also later {{Preconditions.checkNotNull(fc);}}
Is the later needed in the constructor?
-- line 741: the file path to create the builder for.
-- line 730: {{createOpts.add(CreateOpts.donotCreateParent());}}  wondering the need for this
explicit donotCreateParent() call. The default value is anyways false in CreateParent op.
So, is this still needed ?

3. {{FileContextMainOperationsBaseTest}}
-- Can you please extend the test with few build() options like recursive / progress added
?
 

> Add builder interface to FileContext
> ------------------------------------
>
>                 Key: HADOOP-14396
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14396
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.9.0, 3.0.0-alpha3
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HADOOP-14396.00.patch
>
>
> Add builder interface for {{FileContext#create}} and {{FileContext#append}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message