Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7CB56200CAF for ; Wed, 7 Jun 2017 16:38:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7B5EA160BB6; Wed, 7 Jun 2017 14:38:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CB156160BD0 for ; Wed, 7 Jun 2017 16:38:24 +0200 (CEST) Received: (qmail 53517 invoked by uid 500); 7 Jun 2017 14:38:23 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 53498 invoked by uid 99); 7 Jun 2017 14:38:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jun 2017 14:38:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6A2961883A2 for ; Wed, 7 Jun 2017 14:38:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GEnNVQ6jY0ck for ; Wed, 7 Jun 2017 14:38:20 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 691385FCA4 for ; Wed, 7 Jun 2017 14:38:19 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D263DE0AE8 for ; Wed, 7 Jun 2017 14:38:18 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 643F321E0D for ; Wed, 7 Jun 2017 14:38:18 +0000 (UTC) Date: Wed, 7 Jun 2017 14:38:18 +0000 (UTC) From: "Lantao Jin (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-14492) RpcDetailedMetrics and NameNodeMetrics use different rate metrics abstraction cause the Xavgtime confused MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 07 Jun 2017 14:38:25 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040978#comment-16040978 ] Lantao Jin commented on HADOOP-14492: ------------------------------------- Thanks [~xkrogen] to explain. Yes, our DataNode run with multiple storages. Assigning to you is good. I think it better to use a different metrics name like {{WholeDNBlockReportAvgTime}}. > RpcDetailedMetrics and NameNodeMetrics use different rate metrics abstraction cause the Xavgtime confused > --------------------------------------------------------------------------------------------------------- > > Key: HADOOP-14492 > URL: https://issues.apache.org/jira/browse/HADOOP-14492 > Project: Hadoop Common > Issue Type: Bug > Components: metrics > Affects Versions: 2.8.0, 2.7.4 > Reporter: Lantao Jin > Assignee: Erik Krogen > Priority: Minor > > For performance purpose, [HADOOP-13782|https://issues.apache.org/jira/browse/HADOOP-13782] change the metrics behaviour in {{RpcDetailedMetrics}}. > In 2.7.4: > {code} > public class RpcDetailedMetrics { > @Metric MutableRatesWithAggregation rates; > {code} > In old version: > {code} > public class RpcDetailedMetrics { > @Metric MutableRates rates; > {code} > But {{NameNodeMetrics}} still use {{MutableRate}} whatever in the new or old version: > {code} > public class NameNodeMetrics { > @Metric("Block report") MutableRate blockReport; > {code} > It causes the metrics in JMX very different between them. > {quote} > name: "Hadoop:service=NameNode,name=RpcDetailedActivityForPort8030", > modelerType: "RpcDetailedActivityForPort8030", > tag.port: "8030", > tag.Context: "rpcdetailed", > ... > BlockReportNumOps: 237634, > BlockReportAvgTime: 1382, > ... > name: "Hadoop:service=NameNode,name=NameNodeActivity", > modelerType: "NameNodeActivity", > tag.ProcessName: "NameNode", > ... > BlockReportNumOps: 2592932, > BlockReportAvgTime: 19.258064516129032, > ... > {quote} > In the old version. They are correct. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org