Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 6 Jun 2017 04:46:18 +0000 (UTC)
From: "Hongyuan Li (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13076228.1496246316000.924.1496724378316@Atlassian.JIRA>
In-Reply-To: <JIRA.13076228.1496246316000@Atlassian.JIRA>
References: <JIRA.13076228.1496246316000@Atlassian.JIRA> <JIRA.13076228.1496246316276@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (HADOOP-14470) the ternary operator  in
 create method in class CommandWithDestination is redundant
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 06 Jun 2017 04:46:24 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-14470?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16=
032293#comment-16032293 ]=20

Hongyuan Li edited comment on HADOOP-14470 at 6/6/17 4:46 AM:
--------------------------------------------------------------

ping [~stevel@apache.org]=E3=80=81 [~brahmareddy] =E3=80=81[~yzhangal], Cou=
ld you please give me a code review? =20


was (Author: hongyuan li):
ping [~stevel@apache.org]=E3=80=81 [~brahmareddy] =E3=80=81[~yzhangal], Cou=
ldyou please give me a code review? =20

> the ternary operator  in create method in class CommandWithDestination is=
 redundant
> -------------------------------------------------------------------------=
----------
>
>                 Key: HADOOP-14470
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14470
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Hongyuan Li
>            Assignee: Hongyuan Li
>            Priority: Trivial
>         Attachments: HADOOP-14470-001.patch
>
>
> in if statement=EF=BC=8Cthe lazyPersist  is always true, thus the ternary=
 operator is redundant=EF=BC=8C
> {{lazyPersist =3D=3D true}} in if statment, so {{lazyPersist ? 1 : getDef=
aultReplication(item.path)}} is redundant.
>   related code like below, which is in {{org.apache.hadoop.fs.shell.Comma=
ndWithDestination}}  lineNumber : 504 :
> {code:java}
>    FSDataOutputStream create(PathData item, boolean lazyPersist,
>         boolean direct)
>         throws IOException {
>       try {
>         if (lazyPersist) { // in if stament, lazyPersist is always true
>       =E2=80=A6=E2=80=A6
>           return create(item.path,
>                         FsPermission.getFileDefault().applyUMask(
>                             FsPermission.getUMask(getConf())),
>                         createFlags,
>                         getConf().getInt(IO_FILE_BUFFER_SIZE_KEY,
>                             IO_FILE_BUFFER_SIZE_DEFAULT),
>                         lazyPersist ? 1 : getDefaultReplication(item.path=
), // *this is redundant*
>                         getDefaultBlockSize(),
>                         null,
>                         null);
>         } else {
>           return create(item.path, true);
>         }
>       } finally { // might have been created but stream was interrupted
>         if (!direct) {
>           deleteOnExit(item.path);
>         }
>       }
>     }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org