Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 19 Jun 2017 09:59:00 +0000 (UTC)
From: "Hongyuan Li (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.13072656.1494987110000.46368.1497866340130@Atlassian.JIRA>
In-Reply-To: <JIRA.13072656.1494987110000@Atlassian.JIRA>
References: <JIRA.13072656.1494987110000@Atlassian.JIRA> <JIRA.13072656.1494987110607@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (HADOOP-14429) FTPFileSystem#getFsAction
  always returns FsAction.NONE
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 19 Jun 2017 09:59:03 -0000


    [ https://issues.apache.org/jira/browse/HADOOP-14429?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16=
053516#comment-16053516 ]=20

Hongyuan Li edited comment on HADOOP-14429 at 6/19/17 9:58 AM:
---------------------------------------------------------------

[~brahmareddy]=20
1=E3=80=81i forgot to remove unused imports, will remove them in next patch=
.=20
2=E3=80=81some messages can be added into assertEquals and wiil be added in=
 the next patch.
3=E3=80=81since i am not good at naming method, how about using {{getAcesss=
SetFTPFile}} in replace for {{getFTPFile}}

Thnks for your advice. :)

*Update/Correction*    =20

3=E3=80=81 using  {{getAccessPremissionsSetFTPFile}}


was (Author: hongyuan li):
[~brahmareddy]=20
1=E3=80=81i forgot to remove unused imports, will remove them in next patch=
.=20
2=E3=80=81some messages can be added into assertEquals and wiil be added in=
 the next patch.
3=E3=80=81since i am not good at naming method, how about using {{getAcesss=
SetFTPFile}} in replace for {{getFTPFile}}

Thnks for your advice. :)

> FTPFileSystem#getFsAction  always returns FsAction.NONE
> -------------------------------------------------------
>
>                 Key: HADOOP-14429
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14429
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Hongyuan Li
>            Assignee: Hongyuan Li
>         Attachments: HADOOP-14429-001.patch, HADOOP-14429-002.patch, HADO=
OP-14429-003.patch, HADOOP-14429-004.patch, HADOOP-14429-005.patch, HADOOP-=
14429-006.patch, HADOOP-14429-007.patch, HADOOP-14429-008.patch
>
>
>  =20
> {code}
> private FsAction getFsAction(int accessGroup, FTPFile ftpFile) {
>       FsAction action =3D FsAction.NONE;
>       if (ftpFile.hasPermission(accessGroup, FTPFile.READ_PERMISSION)) {
>       action.or(FsAction.READ);
>   }
>     if (ftpFile.hasPermission(accessGroup, FTPFile.WRITE_PERMISSION)) {
>       action.or(FsAction.WRITE);
>     }
>     if (ftpFile.hasPermission(accessGroup, FTPFile.EXECUTE_PERMISSION)) {
>       action.or(FsAction.EXECUTE);
>     }
>     return action;
>   }
> {code}
> from code above, we can see that the  getFsAction method doesnot modify t=
he action generated by FsAction action =3D FsAction.NONE,which means it ret=
urn FsAction.NONE all the time;


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org