hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ravi Prakash (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-14597) Native compilation broken with OpenSSL-1.1.0 because EVP_CIPHER_CTX has been made opaque
Date Tue, 27 Jun 2017 23:28:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065657#comment-16065657
] 

Ravi Prakash edited comment on HADOOP-14597 at 6/27/17 11:27 PM:
-----------------------------------------------------------------

HADOOP-14597.00.patch and HADOOP-14597.01.patch are bad. They are passing a [{{EVP_CIPHER_CTX}}|https://github.com/openssl/openssl/blob/master/crypto/evp/evp_locl.h#L24]
to [{{EVP_CIPHER_flags}}|https://github.com/openssl/openssl/blob/master/crypto/evp/evp_lib.c#L196]
which actually expects [{{EVP_CIPHER}}|https://github.com/openssl/openssl/blob/master/crypto/include/internal/evp_int.h#L115]
. These are two different structs (none inheriting the other).

I am now using the proper method and I'm guessing the openssl devs intended for us to use
it this way. 

Can someone please review and commit?


was (Author: raviprak):
HADOOP-14597.00.patch and HADOOP-14597.01.patch are bad. They are passing a [{{EVP_CIPHER_CTX}}|https://github.com/openssl/openssl/blob/master/crypto/evp/evp_locl.h#L24]
to [{{EVP_CIPHER_flags}}|https://github.com/openssl/openssl/blob/master/crypto/evp/evp_lib.c#L196]
which actually expects [{{EVP_CIPHER}}|https://github.com/openssl/openssl/blob/master/crypto/include/internal/evp_int.h#L115]
. These are two different structs (none inheriting the other).
I am not using the proper method and I'm guessing the openssl devs intended for us to use
it this way. 

Can someone please review and commit?

> Native compilation broken with OpenSSL-1.1.0 because EVP_CIPHER_CTX has been made opaque
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14597
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14597
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha4
>         Environment: openssl-1.1.0
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>         Attachments: HADOOP-14597.00.patch, HADOOP-14597.01.patch, HADOOP-14597.02.patch
>
>
> Trying to build Hadoop trunk on Fedora 26 which has openssl-devel-1.1.0 fails with this
error
> {code}[WARNING] /home/raviprak/Code/hadoop/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/OpensslCipher.c:
In function ‘check_update_max_output_len’:
> [WARNING] /home/raviprak/Code/hadoop/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/crypto/OpensslCipher.c:256:14:
error: dereferencing pointer to incomplete type ‘EVP_CIPHER_CTX {aka struct evp_cipher_ctx_st}’
> [WARNING]    if (context->flags & EVP_CIPH_NO_PADDING) {
> [WARNING]               ^~
> {code}
> https://github.com/openssl/openssl/issues/962 mattcaswell says
> {quote}
> One of the primary differences between master (OpenSSL 1.1.0) and the 1.0.2 version is
that many types have been made opaque, i.e. applications are no longer allowed to look inside
the internals of the structures
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message