hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14572) General improvements to Azure test cases
Date Thu, 22 Jun 2017 20:18:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059939#comment-16059939
] 

Steve Loughran commented on HADOOP-14572:
-----------------------------------------

These are all failing for the same reason: brittle to changes in thread configuration in test
setup; use of hard-coded strings in exceptions, no details. 
{code}
testDeleteLargeFolderDisableThreads(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 40.548 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteLargeFolderDisableThreads(TestFileSystemOperationsWithThreads.java:307)

testRenameThreadPoolExceptionFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 5.914 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameThreadPoolExceptionFailure(TestFileSystemOperationsWithThreads.java:559)

testDeleteSmallFolderDisableThreadsDisableFlatListing(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 4.983 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteSmallFolderDisableThreadsDisableFlatListing(TestFileSystemOperationsWithThreads.java:332)

testRenameLargeFolderDisableThreads(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 46.594 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameLargeFolderDisableThreads(TestFileSystemOperationsWithThreads.java:187)

testRenameThreadPoolExecuteFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 5.751 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameThreadPoolExecuteFailure(TestFileSystemOperationsWithThreads.java:590)

testDeleteThreadPoolExecuteFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 4.562 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteThreadPoolExecuteFailure(TestFileSystemOperationsWithThreads.java:396)

testDeleteLargeFolderWithThreads(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 33.667 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteLargeFolderWithThreads(TestFileSystemOperationsWithThreads.java:283)

testRenameSingleRenameException(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 3.683 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameSingleRenameException(TestFileSystemOperationsWithThreads.java:710)

testDeleteSingleDeleteFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 3.744 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteSingleDeleteFailure(TestFileSystemOperationsWithThreads.java:499)

testDeleteThreadPoolExecuteSingleThreadFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 4.404 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteThreadPoolExecuteSingleThreadFailure(TestFileSystemOperationsWithThreads.java:430)

testDeleteThreadPoolTerminationFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 3.677 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteThreadPoolTerminationFailure(TestFileSystemOperationsWithThreads.java:475)

testDeleteSingleDeleteException(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 3.757 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteSingleDeleteException(TestFileSystemOperationsWithThreads.java:531)

testRenameLargeFolderWithThreads(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 37.682 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameLargeFolderWithThreads(TestFileSystemOperationsWithThreads.java:161)

testRenameThreadPoolTerminationFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 4.049 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameThreadPoolTerminationFailure(TestFileSystemOperationsWithThreads.java:669)

testDeleteSmallFolderWithThreads(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 4.407 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteSmallFolderWithThreads(TestFileSystemOperationsWithThreads.java:257)

testRenameThreadPoolExecuteSingleThreadFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 475.951 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameThreadPoolExecuteSingleThreadFailure(TestFileSystemOperationsWithThreads.java:624)

testRenameSmallFolderWithThreads(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 4.7 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameSmallFolderWithThreads(TestFileSystemOperationsWithThreads.java:134)

testDeleteThreadPoolExceptionFailure(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 4.5 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testDeleteThreadPoolExceptionFailure(TestFileSystemOperationsWithThreads.java:364)

testRenameSmallFolderDisableThreadsDisableFlatListing(org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads)
 Time elapsed: 5.56 sec  <<< FAILURE!
java.lang.AssertionError: null
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.hadoop.fs.azure.TestFileSystemOperationsWithThreads.testRenameSmallFolderDisableThreadsDisableFlatListing(TestFileSystemOperationsWithThreads.java:213)


{code}

> General improvements to Azure test cases
> ----------------------------------------
>
>                 Key: HADOOP-14572
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14572
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure, test
>    Affects Versions: 2.9.0
>            Reporter: Steve Loughran
>            Priority: Minor
>
> JIRA to track list of things to tweak in Azure tests
> including
> * replace all uses of System.out with logging
> * assertions to have error text
> * tests to have timeouts (can be done in base class)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message