hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14542) Add IOUtils.cleanup or something that accepts slf4j logger API
Date Wed, 21 Jun 2017 02:32:02 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056864#comment-16056864
] 

Akira Ajisaka commented on HADOOP-14542:
----------------------------------------

Thanks [~vagarychen] for the update. Would you add null check for the {{logger}}?

> Add IOUtils.cleanup or something that accepts slf4j logger API
> --------------------------------------------------------------
>
>                 Key: HADOOP-14542
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14542
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Akira Ajisaka
>            Assignee: Chen Liang
>         Attachments: HADOOP-14542.001.patch, HADOOP-14542.002.patch
>
>
> Split from HADOOP-14539.
> Now IOUtils.cleanup only accepts commons-logging logger API. Now we are migrating the
APIs to slf4j, slf4j logger API should be accepted as well. Adding {{IOUtils.cleanup(Logger,
Closeable...)}} causes {{IOUtils.cleanup(null, Closeable...)}} to fail (incompatible change),
so it's better to change the method name to avoid the conflict.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message