hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14524) Make CryptoCodec Closeable so it can be cleaned up proactively
Date Thu, 15 Jun 2017 20:44:01 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051032#comment-16051032
] 

Andrew Wang commented on HADOOP-14524:
--------------------------------------

+1 LGTM

> Make CryptoCodec Closeable so it can be cleaned up proactively
> --------------------------------------------------------------
>
>                 Key: HADOOP-14524
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14524
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-14524.01.patch
>
>
> See HADOOP-14523 for motivation. Credit to [~misha@cloudera.com] for reporting initially
there.
> Basically, the {{CryptoCodec}} class is not a closeable, but the {{OpensslAesCtrCryptoCodec}}
implementation of it contains a closeable member (the Random object). Currently it is left
for {{finalize()}} to clean up, this depends on when a FGC is run, and would create problems
if {{OpensslAesCtrCryptoCodec}} is used with {{OsSecureRandom}}, which could let OS run out
of FDs on {{/dev/urandom}} if too many codecs created.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message