hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14503) Make RollingAverages a mutable metric
Date Thu, 08 Jun 2017 21:09:22 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043441#comment-16043441
] 

Arpit Agarwal commented on HADOOP-14503:
----------------------------------------

Thanks for contributing this improvement [~hanishakoneru]. A few comments:
# The following log message should be debug in both constructor and init.
{code}
    LOG.info("MutableRollingAverages has been initialized with default values: " +
        "Window Size = " + WINDOW_SIZE_MS_DEFAULT + "ms " +
        ", Number of Windows = " + NUM_WINDOWS_DEFAULT +
        " and Metric value name = " + METRIC_VALUE_NAME_DEFAULT);
{code}
# The init method should be synchronized.
# {{init}} should cancel the previously scheduled task in the constructor.
# Also the {{SCHEDULER.scheduleAtFixedRate}} call can be skipped if init() is invoked with
the same windowSizeMs and numWindows as before.

> Make RollingAverages a mutable metric
> -------------------------------------
>
>                 Key: HADOOP-14503
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14503
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: common
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>         Attachments: HADOOP-14503.001.patch
>
>
> RollingAverages metric extends on MutableRatesWithAggregation metric and maintains a
group of rolling average metrics. This class should be allowed to register as a metric with
the MetricSystem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message