hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Fabbri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14499) Findbugs warning in LocalMetadataStore
Date Thu, 08 Jun 2017 02:08:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042079#comment-16042079
] 

Aaron Fabbri commented on HADOOP-14499:
---------------------------------------

I feel like we need to define prune() semantics a little better, along with the algorithm
that satisfies them.. I'll admit I did not carefully review the LocalMetadataStore's prune()
implementation before, since it is not really used in production (just for test).

After applying this patch, for example, I'm not sure why we remove directories when they are
empty.  An empty directory is a valid thing to track but this function seems to discard them
regardless of age.  Maybe you can describe the intended algorithm a bit better, or we can
discuss in person and post our notes to this JIRA?

> Findbugs warning in LocalMetadataStore
> --------------------------------------
>
>                 Key: HADOOP-14499
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14499
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-14499-HADOOP-13345.001.patch
>
>
> First saw this raised by Yetus on HADOOP-14433:
> {code}
> Bug type UC_USELESS_OBJECT (click for details)
> In class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore
> In method org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore.prune(long)
> Value ancestors
> Type java.util.LinkedList
> At LocalMetadataStore.java:[line 300]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message