hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Mackrory (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-14499) Findbugs warning in LocalMetadataStore
Date Wed, 07 Jun 2017 22:08:18 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sean Mackrory updated HADOOP-14499:
-----------------------------------
    Attachment: HADOOP-14499-HADOOP-13345.001.patch

If we're looking for a quick solution to the findbugs warning showing up in Yetus, we can
simply remove the 2 lines that reference ancestors because findbugs is right - they're not
actually doing anything.

My best guess as to why that was added in the first place, though, is that I was thinking
about updating parents. Since directories don't (necessarily) get a modification, it's not
clear how they should be dealt with, so the interface says files MUST get pruned, and directories
MAY. DynamoDB just leaves directories at the moment. We need to do at least a little more
than that for the Local implementation because separate references to pruned files may persist
in parents, and they may be marked as being authoritative. This patch completes the process
of traversing the parents to remove expired file references from listings, mark their parents
as not authoritative, and actually remove directories if they're completely empty.

> Findbugs warning in LocalMetadataStore
> --------------------------------------
>
>                 Key: HADOOP-14499
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14499
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>         Attachments: HADOOP-14499-HADOOP-13345.001.patch
>
>
> First saw this raised by Yetus on HADOOP-14433:
> {code}
> Bug type UC_USELESS_OBJECT (click for details)
> In class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore
> In method org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore.prune(long)
> Value ancestors
> Type java.util.LinkedList
> At LocalMetadataStore.java:[line 300]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message