hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14476) make InconsistentAmazonS3Client usable in downstream tests
Date Tue, 06 Jun 2017 12:38:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038795#comment-16038795
] 

Steve Loughran commented on HADOOP-14476:
-----------------------------------------

patch looks good. For the extra test, something like

{code}
delete(dir, true)
(wait for it to absolutely not be there via LambdaTest eventually())
touch(new Path(dir, "child")
FileStatus st = verifyPathExists(fs, "parent dir", dir)
assertIsDirectory(st)
{code}



> make InconsistentAmazonS3Client usable in downstream tests
> ----------------------------------------------------------
>
>                 Key: HADOOP-14476
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14476
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Aaron Fabbri
>         Attachments: HADOOP-14476-HADOOP-13345.001.patch
>
>
> It's important for downstream apps to be able to verify that s3guard works by making
the AWS client inconsistent (so demonstrate problems), then turn s3guard on to verify that
they go away. 
> This can be done by exposing the {{InconsistentAmazonS3Client}}
> # move the factory to the production source
> # make delay configurable for when you want a really long delay
> # have factory code log @ warn when a non-default factory is used.
> # mention in s3a testing.md
> I think we could look at the name of the option, {{fs.s3a.s3.client.factory.impl}} too.
I'd like something which has "internal" in it, and without the duplication of s3a.s3



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message