hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14476) make InconsistentAmazonS3Client usable in downstream tests
Date Wed, 07 Jun 2017 20:39:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041571#comment-16041571

Mingliang Liu commented on HADOOP-14476:

I like this idea and patch. It's really handy stuff in testing.

The v3 patch looks good to me overall. I have an early comment, per [HADOOP-13616], we have
to add blank line before code snippet, e.g.
899	You can also configure how long you want the delay in visibility to last.
900	The default is 5000 milliseconds (five seconds).
901	```
902	<property>
903	  <name>fs.s3a.failinject.inconsistency.msec</name>
904	  <value>5000</value>
905	</property>
906	```

> make InconsistentAmazonS3Client usable in downstream tests
> ----------------------------------------------------------
>                 Key: HADOOP-14476
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14476
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3, test
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Aaron Fabbri
>         Attachments: HADOOP-14476-HADOOP-13345.001.patch, HADOOP-14476-HADOOP-13345.002.patch,
> It's important for downstream apps to be able to verify that s3guard works by making
the AWS client inconsistent (so demonstrate problems), then turn s3guard on to verify that
they go away. 
> This can be done by exposing the {{InconsistentAmazonS3Client}}
> # move the factory to the production source
> # make delay configurable for when you want a really long delay
> # have factory code log @ warn when a non-default factory is used.
> # mention in s3a testing.md
> I think we could look at the name of the option, {{fs.s3a.s3.client.factory.impl}} too.
I'd like something which has "internal" in it, and without the duplication of s3a.s3

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message