hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14469) FTPFileSystem#listStatus get currentPath and parentPath at the same time, causing recursively list action endless
Date Fri, 16 Jun 2017 16:07:00 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052075#comment-16052075
] 

Hadoop QA commented on HADOOP-14469:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 15s{color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 19s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m  4s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 35s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  4s{color} |
{color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 22s{color} | {color:red}
hadoop-common-project/hadoop-common in trunk has 19 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 49s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 38s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m  7s{color} |
{color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 10m  7s{color} | {color:red}
root generated 1 new + 821 unchanged - 2 fixed = 822 total (was 823) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 36s{color}
| {color:orange} hadoop-common-project/hadoop-common: The patch generated 1 new + 6 unchanged
- 0 fixed = 7 total (was 6) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m  1s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 32s{color} | {color:red}
hadoop-common-project/hadoop-common generated 1 new + 19 unchanged - 0 fixed = 20 total (was
19) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 55s{color} |
{color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  8m 39s{color} | {color:red}
hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 34s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 18s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-common-project/hadoop-common |
|  |  Possible null pointer dereference of dirEntries in org.apache.hadoop.fs.ftp.FTPFileSystem.delete(FTPClient,
Path, boolean)  Dereferenced at FTPFileSystem.java:dirEntries in org.apache.hadoop.fs.ftp.FTPFileSystem.delete(FTPClient,
Path, boolean)  Dereferenced at FTPFileSystem.java:[line 414] |
| Failed junit tests | hadoop.test.TestLambdaTestUtils |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14469 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12873298/HADOOP-14469-004.patch
|
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  findbugs
 checkstyle  |
| uname | Linux 57cdecff6df5 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 942ecbb |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| findbugs | https://builds.apache.org/job/PreCommit-HADOOP-Build/12546/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
|
| javac | https://builds.apache.org/job/PreCommit-HADOOP-Build/12546/artifact/patchprocess/diff-compile-javac-root.txt
|
| checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/12546/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HADOOP-Build/12546/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
|
| unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/12546/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12546/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
|
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12546/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> FTPFileSystem#listStatus get currentPath and parentPath at the same time, causing recursively
list action endless
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14469
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14469
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, tools/distcp
>    Affects Versions: 3.0.0-alpha3
>         Environment: ftp build by windows7 + Serv-U_64 12.1.0.8 
> code runs any os
>            Reporter: Hongyuan Li
>            Assignee: Hongyuan Li
>            Priority: Critical
>         Attachments: HADOOP-14469-001.patch, HADOOP-14469-002.patch, HADOOP-14469-003.patch
>
>
> for some ftpsystems, liststatus method will return new Path(".") and new Path(".."),
thus causing list op looping.for example, Serv-U
> We can see the logic in code below:
> {code}
>   private FileStatus[] listStatus(FTPClient client, Path file)
>       throws IOException {
>     ……
>     FileStatus[] fileStats = new FileStatus[ftpFiles.length];
>     for (int i = 0; i < ftpFiles.length; i++) {
>       fileStats[i] = getFileStatus(ftpFiles[i], absolute);
>     }
>     return fileStats;
>   }
> {code}
> {code}
> public void test() throws Exception{
>     FTPFileSystem ftpFileSystem = new FTPFileSystem();
>     ftpFileSystem.initialize(new Path("ftp://test:123456@192.168.44.1/").toUri(),
>         new Configuration());
>     FileStatus[] fileStatus  = ftpFileSystem.listStatus(new Path("/new"));
>     for(FileStatus fileStatus1 : fileStatus)
>       System.out.println(fileStatus1);
> }
> {code}
> using test code below, the test results list below
> {code}
> FileStatus{path=ftp://test:123456@192.168.44.1/new; isDirectory=true; modification_time=1496716980000;
access_time=0; owner=user; group=group; permission=---------; isSymlink=false}
> FileStatus{path=ftp://test:123456@192.168.44.1/; isDirectory=true; modification_time=1496716980000;
access_time=0; owner=user; group=group; permission=---------; isSymlink=false}
> FileStatus{path=ftp://test:123456@192.168.44.1/new/hadoop; isDirectory=true; modification_time=1496716980000;
access_time=0; owner=user; group=group; permission=---------; isSymlink=false}
> FileStatus{path=ftp://test:123456@192.168.44.1/new/HADOOP-14431-002.patch; isDirectory=false;
length=2036; replication=1; blocksize=4096; modification_time=1495797780000; access_time=0;
owner=user; group=group; permission=---------; isSymlink=false}
> FileStatus{path=ftp://test:123456@192.168.44.1/new/HADOOP-14486-001.patch; isDirectory=false;
length=1322; replication=1; blocksize=4096; modification_time=1496716980000; access_time=0;
owner=user; group=group; permission=---------; isSymlink=false}
> FileStatus{path=ftp://test:123456@192.168.44.1/new/hadoop-main; isDirectory=true; modification_time=1495797120000;
access_time=0; owner=user; group=group; permission=---------; isSymlink=false}
> {code}
> In results above, {{FileStatus{path=ftp://test:123456@192.168.44.1/new; ……}} is obviously
the current Path, and  
> {{FileStatus{path=ftp://test:123456@192.168.44.1/;……}}  is obviously the parent Path.
> So, if we want to walk the directory recursively, it will stuck.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message