hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hongyuan Li (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-14469) the listStatus method of FTPFileSystem should ignore the path "." and ".."
Date Thu, 01 Jun 2017 01:24:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031433#comment-16031433
] 

Hongyuan Li edited comment on HADOOP-14469 at 6/1/17 1:23 AM:
--------------------------------------------------------------

[~stevel@apache.org]、 [~brahmareddy] 、[~yzhangal], can you please give me a code review?
 None of the findbugs/unit test warnings seem to be related to the change.


was (Author: hongyuan li):
[~stevel@apache.org] [~brahmareddy] [~Yongjun Zhang] , can you please give me a code review?
 None of the findbugs/unit test warnings seem to be related to the change.

> the listStatus method of FTPFileSystem should ignore the path "."  and ".."
> ---------------------------------------------------------------------------
>
>                 Key: HADOOP-14469
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14469
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>            Reporter: Hongyuan Li
>            Assignee: Hongyuan Li
>         Attachments: HADOOP-14469-001.patch, HADOOP-14469-002.patch, HADOOP-14469-003.patch
>
>
> for some ftpsystems, liststatus method will return new Path(".") and new Path(".."),
thus causing list op looping.for example, Serv-U
> We can see the logic in code below:
> {code}
>   private FileStatus[] listStatus(FTPClient client, Path file)
>       throws IOException {
>     ……
>     FileStatus[] fileStats = new FileStatus[ftpFiles.length];
>     for (int i = 0; i < ftpFiles.length; i++) {
>       fileStats[i] = getFileStatus(ftpFiles[i], absolute);
>     }
>     return fileStats;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message