hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14465) LdapGroupsMapping - support user and group search base
Date Fri, 09 Jun 2017 18:20:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044800#comment-16044800
] 

Mingliang Liu commented on HADOOP-14465:
----------------------------------------

+1

Minor comments:
# By
{quote}
use getTrimmed() to strip off whitespace.
{quote}
I think Steve was saying
{code}
userbaseDN = conf.get(USER_BASE_DN_KEY, baseDN).trim();
{code}
to be replaced with
{code}
userbaseDN = conf.getTrimmed(USER_BASE_DN_KEY, baseDN);
{code}
The first will work though I think.
# The two test code _may_ be reused by creating a helper method: {{private void testGetGroupsWithBaseDN(Configuration
conf, String userBaseDN, String groupBaseDN)}}.

> LdapGroupsMapping - support user and group search base
> ------------------------------------------------------
>
>                 Key: HADOOP-14465
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14465
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>         Attachments: 0001-HADOOP-14465-LdapGroupsMapping-support-user-and-grou.patch,
HADOOP-14465-v2.patch, HADOOP-14465-v4.patch
>
>
> org.apache.hadoop.security.LdapGroupsMapping currently supports hadoop.security.group.mapping.ldap.base
as search base for both user and group searches. However, this doesn't work when user and
group search bases are different like ou=Users,dc=xxx,dc=com and ou=Groups,dc=xxx,dc=com.

> Expose different configs for user and group search base which defaults to the existing
hadoop.security.group.mapping.ldap.base config



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message