hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingliang Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14423) s3guard will set file length to -1 on a putObjectDirect(stream, -1) call
Date Thu, 29 Jun 2017 23:03:02 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069157#comment-16069157
] 

Mingliang Liu commented on HADOOP-14423:
----------------------------------------

+1


> s3guard will set file length to -1 on a putObjectDirect(stream, -1) call
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-14423
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14423
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-14423-HADOOP-13345-001.patch, HADOOP-14423-HADOOP-13345-002.patch
>
>
> You can pass a negative number into {{S3AFileSystem.putObjectDirect}}, which means "put
until the end of the stream". S3guard has been using this {{len}} argument: it needs to be
using the actual number of bytes uploaded. Also relevant with client side encryption, when
the amount of data put > the amount of data in the file or stream.
> Noted in the committer branch after I added some more assertions, I've changed it there
so making changes to S3AFS.putObjectDirect to pull the content length to pass in to finishedWrite()
from the {{PutObjectResult}} instead. This can be picked into the s3guard branch



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message