hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rushabh S Shah (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-14521) KMS client needs retry logic
Date Wed, 14 Jun 2017 14:14:00 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rushabh S Shah updated HADOOP-14521:
------------------------------------
    Attachment: HDFS-11804-trunk-8.patch

[~xiaochen]: thanks for the review.
Attaching a patch with more informative log message.
Below is the diff between patch#7 and patch#8 for quick reference.
{noformat}
diff ~/patches/jira/HDFS-11804-trunk-7.patch ~/patches/jira/HDFS-11804-trunk-8.patch
103c103
< @@ -79,24 +87,73 @@ public LoadBalancingKMSClientProvider(KMSClientProvider[] providers,
---
> @@ -79,24 +87,79 @@ public LoadBalancingKMSClientProvider(KMSClientProvider[] providers,
167c167,173
< +              + " providers in the group or the exception is not recoverable.");
---
> +              + " providers(depending on {}={} setting and numProviders={})"
> +              + " in the group OR the exception is not recoverable",
> +              CommonConfigurationKeysPublic.KMS_CLIENT_FAILOVER_MAX_RETRIES_KEY
> +              , getConf().getInt(
> +                  CommonConfigurationKeysPublic.
> +                  KMS_CLIENT_FAILOVER_MAX_RETRIES_KEY, providers.length),
> +              providers.length);
{noformat}


> KMS client needs retry logic
> ----------------------------
>
>                 Key: HADOOP-14521
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14521
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>         Attachments: HDFS-11804-trunk-1.patch, HDFS-11804-trunk-2.patch, HDFS-11804-trunk-3.patch,
HDFS-11804-trunk-4.patch, HDFS-11804-trunk-5.patch, HDFS-11804-trunk-6.patch, HDFS-11804-trunk-7.patch,
HDFS-11804-trunk-8.patch, HDFS-11804-trunk.patch
>
>
> The kms client appears to have no retry logic – at all.  It's completely decoupled
from the ipc retry logic.  This has major impacts if the KMS is unreachable for any reason,
including but not limited to network connection issues, timeouts, the +restart during an upgrade+.
> This has some major ramifications:
> # Jobs may fail to submit, although oozie resubmit logic should mask it
> # Non-oozie launchers may experience higher rates if they do not already have retry logic.
> # Tasks reading EZ files will fail, probably be masked by framework reattempts
> # EZ file creation fails after creating a 0-length file – client receives EDEK in
the create response, then fails when decrypting the EDEK
> # Bulk hadoop fs copies, and maybe distcp, will prematurely fail



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message