hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Moss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-13048) Improvements to StatD metrics2 sink
Date Tue, 06 Jun 2017 18:08:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-13048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039373#comment-16039373
] 

Michael Moss commented on HADOOP-13048:
---------------------------------------

Hi. Please see this comment regarding a peculiarity with the existing StatsD metrics2 sink:
https://issues.apache.org/jira/browse/HADOOP-12360?focusedCommentId=16036925&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16036925

It was suggested that we might revisit/take up this work on this ticket.

> Improvements to StatD metrics2 sink
> -----------------------------------
>
>                 Key: HADOOP-13048
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13048
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Xiao Chen
>            Priority: Minor
>
> In some recent offline review of feature HADOOP-12360, [~jojochuang] has some good comments.
The feature is overall a nice feature, but can have some improvements:
> - Validation should be more robust:
> {code}
> public void init(SubsetConfiguration conf) {
>     // Get StatsD host configurations.
>     final String serverHost = conf.getString(SERVER_HOST_KEY);
>     final int serverPort = Integer.parseInt(conf.getString(SERVER_PORT_KEY));
> {code}
> - Javadoc should be more accurate:
> ** Inconsistency host.name v.s. hostname
> ** Could have better explanation regarding service name and process name
> - {{StatsDSink#writeMetric}} should be private.
> - Hopefully a document about this and other metric sinks.
> Thanks Wei-Chiu and [~dlmarion] for the contribution!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message