hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Moss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-12360) Create StatsD metrics2 sink
Date Fri, 02 Jun 2017 15:05:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-12360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034826#comment-16034826
] 

Michael Moss commented on HADOOP-12360:
---------------------------------------

Hi, I'm curious what this section of code is trying to achieve:
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java#L103

It seems that in some cases, for some metrics (JVM metrics for example), the sn (serviceName)
variable is overridden, which breaks the configured prefix: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/StatsDSink.java#L91

Wondering if this was intended?

> Create StatsD metrics2 sink
> ---------------------------
>
>                 Key: HADOOP-12360
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12360
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: metrics
>    Affects Versions: 2.7.1
>            Reporter: Dave Marion
>            Assignee: Dave Marion
>            Priority: Minor
>             Fix For: 2.8.0, 3.0.0-alpha1
>
>         Attachments: HADOOP-12360.001.patch, HADOOP-12360.002.patch, HADOOP-12360.003.patch,
HADOOP-12360.004.patch, HADOOP-12360.005.patch, HADOOP-12360.006.patch, HADOOP-12360.007.patch,
HADOOP-12360.008.patch, HADOOP-12360.009.patch, HADOOP-12360.010.patch
>
>
> Create a metrics sink that pushes to a StatsD daemon.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message