Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ED43A200C85 for ; Tue, 30 May 2017 18:21:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EC000160BDC; Tue, 30 May 2017 16:21:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3E58D160BC1 for ; Tue, 30 May 2017 18:21:09 +0200 (CEST) Received: (qmail 16159 invoked by uid 500); 30 May 2017 16:21:08 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 16145 invoked by uid 99); 30 May 2017 16:21:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 May 2017 16:21:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 060FA180647 for ; Tue, 30 May 2017 16:21:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DLSB6IgkxrIs for ; Tue, 30 May 2017 16:21:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9FF765FDFD for ; Tue, 30 May 2017 16:21:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C1B9AE05F7 for ; Tue, 30 May 2017 16:21:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 12E6321B61 for ; Tue, 30 May 2017 16:21:05 +0000 (UTC) Date: Tue, 30 May 2017 16:21:05 +0000 (UTC) From: "Brahma Reddy Battula (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-14456) Modifier 'static' is redundant for inner enums less MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 30 May 2017 16:21:10 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16029639#comment-16029639 ] Brahma Reddy Battula commented on HADOOP-14456: ----------------------------------------------- [~linzhangbing] thanks for updating the patch, +1 on latest patch.{{findbugs}} and {{checkstyle}} are not introduced by this patch.Even {{checkstyle}} can be tracked on seperate jira. > Modifier 'static' is redundant for inner enums less > --------------------------------------------------- > > Key: HADOOP-14456 > URL: https://issues.apache.org/jira/browse/HADOOP-14456 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 3.0.0-alpha4 > Reporter: ZhangBing Lin > Assignee: ZhangBing Lin > Priority: Minor > Attachments: HADOOP-14456.001.patch, HADOOP-14456.002.patch > > > Java enumeration type is a static constant, implicitly modified with static final,Modifier 'static' is redundant for inner enums less.So I suggest deleting the 'static' modifier. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org