Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8E2F3200C6E for ; Mon, 8 May 2017 11:56:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8CDE7160B99; Mon, 8 May 2017 09:56:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE2BE160BA5 for ; Mon, 8 May 2017 11:56:08 +0200 (CEST) Received: (qmail 59488 invoked by uid 500); 8 May 2017 09:56:07 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 59396 invoked by uid 99); 8 May 2017 09:56:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 May 2017 09:56:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 37D771A7A9E for ; Mon, 8 May 2017 09:56:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.702 X-Spam-Level: X-Spam-Status: No, score=-98.702 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id C8u6lx6beopN for ; Mon, 8 May 2017 09:56:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BD78F5FC43 for ; Mon, 8 May 2017 09:56:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D72C8E0BE1 for ; Mon, 8 May 2017 09:56:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4E58521DF9 for ; Mon, 8 May 2017 09:56:04 +0000 (UTC) Date: Mon, 8 May 2017 09:56:04 +0000 (UTC) From: "Steve Loughran (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-14180) FileSystem contract tests to replace JUnit 3 with 4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 08 May 2017 09:56:09 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000528#comment-16000528 ] Steve Loughran commented on HADOOP-14180: ----------------------------------------- OK, this looks good, but the Azure tests are NPE-ing. I suspect we'd have problems with the swift & s3 ones, but as they aren't being run by Yetus, we aren't catching those. Whatever fixes Azure is what we (I?) will have to apply there. Do you know why the Azure tests are failing? If we can address that then I'll apply this patch locally and deal with the other blobstores > FileSystem contract tests to replace JUnit 3 with 4 > --------------------------------------------------- > > Key: HADOOP-14180 > URL: https://issues.apache.org/jira/browse/HADOOP-14180 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Reporter: Mingliang Liu > Assignee: Xiaobing Zhou > Labels: test > Attachments: HADOOP-14180.000.patch > > > This is from discussion in [HADOOP-14170], as Steve commented: > {quote} > ...it's time to move this to JUnit 4, annotate all tests with @test, and make the test cases skip if they don't have the test FS defined. JUnit 3 doesn't support Assume, so when I do test runs without the s3n or s3 fs specced, I get lots of errors I just ignore. > ...Move to Junit 4, and, in our own code, find everywhere we've subclassed a method to make the test a no-op, and insert an Assume.assumeTrue(false) in there so they skip properly. > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org