Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4C1FA200C7F for ; Wed, 24 May 2017 19:32:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4ACB9160BD0; Wed, 24 May 2017 17:32:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 92590160BA5 for ; Wed, 24 May 2017 19:32:09 +0200 (CEST) Received: (qmail 56084 invoked by uid 500); 24 May 2017 17:32:08 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 56072 invoked by uid 99); 24 May 2017 17:32:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 May 2017 17:32:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 23D9BC0C40 for ; Wed, 24 May 2017 17:32:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id jZiQmI2la7U7 for ; Wed, 24 May 2017 17:32:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 013D15FD9C for ; Wed, 24 May 2017 17:32:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ECC3BE0DBC for ; Wed, 24 May 2017 17:32:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7B22123FDE for ; Wed, 24 May 2017 17:32:04 +0000 (UTC) Date: Wed, 24 May 2017 17:32:04 +0000 (UTC) From: "Brahma Reddy Battula (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-14166) Reset the DecayRpcScheduler AvgResponseTime metric to zero when queue is not used MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 24 May 2017 17:32:10 -0000 [ https://issues.apache.org/jira/browse/HADOOP-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brahma Reddy Battula updated HADOOP-14166: ------------------------------------------ Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.8.2 3.0.0-alpha3 2.9.0 Status: Resolved (was: Patch Available) Committed to {{trunk}},{{branch-2}} and {{branch-2.8}}. [~surendrasingh] thanks for your contribution. it's nice finding.. [~xyao] thanks for additional review. > Reset the DecayRpcScheduler AvgResponseTime metric to zero when queue is not used > --------------------------------------------------------------------------------- > > Key: HADOOP-14166 > URL: https://issues.apache.org/jira/browse/HADOOP-14166 > Project: Hadoop Common > Issue Type: Bug > Components: common > Reporter: Surendra Singh Lilhore > Assignee: Surendra Singh Lilhore > Fix For: 2.9.0, 3.0.0-alpha3, 2.8.2 > > Attachments: HADOOP-14166.001.patch > > > {noformat} > "name" : "Hadoop:service=NameNode,name=DecayRpcSchedulerMetrics2.ipc.8020", > "modelerType" : "DecayRpcSchedulerMetrics2.ipc.8020", > "tag.Context" : "ipc.8020", > "tag.Hostname" : "host1", > "DecayedCallVolume" : 3, > "UniqueCallers" : 1, > "Caller(root).Volume" : 266, > "Caller(root).Priority" : 3, > "Priority.0.AvgResponseTime" : 6.151201023385511E-5, > "Priority.1.AvgResponseTime" : 0.0, > "Priority.2.AvgResponseTime" : 0.0, > "Priority.3.AvgResponseTime" : 1.184686336544601, > "Priority.0.CompletedCallVolume" : 0, > "Priority.1.CompletedCallVolume" : 0, > "Priority.2.CompletedCallVolume" : 0, > "Priority.3.CompletedCallVolume" : 2, > "CallVolume" : 266 > {noformat} > "Priority.0.AvgResponseTime" is always "6.151201023385511E-5" even the queue is not used for long time. > {code} > if (lastAvg > PRECISION || averageResponseTime > PRECISION) { > if (enableDecay) { > final double decayed = decayFactor * lastAvg + averageResponseTime; > LOG.info("Decayed " + i + " time " + decayed); > responseTimeAvgInLastWindow.set(i, decayed); > } else { > responseTimeAvgInLastWindow.set(i, averageResponseTime); > } > } > {code} > we should reset it to zero when above condition is false. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: common-issues-help@hadoop.apache.org