hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14414) Calling maven-site-plugin directly for docs profile is unnecessary
Date Sat, 13 May 2017 17:33:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009424#comment-16009424
] 

Hadoop QA commented on HADOOP-14414:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 22s{color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} |
{color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 50s{color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 26s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m 49s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 42s{color} |
{color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 30s{color}
| {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 24s{color} |
{color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 15s{color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m  9s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m 49s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 16m 49s{color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  2m 37s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}  1m 29s{color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  5s{color} | {color:green}
The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 19s{color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 13s{color} | {color:green}
hadoop-auth in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m  6s{color} | {color:green}
hadoop-kms in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  3m 35s{color} | {color:green}
hadoop-hdfs-httpfs in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  8m  1s{color} | {color:red}
hadoop-sls in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 35s{color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 84m  4s{color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.yarn.sls.TestSLSRunner |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14414 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12867946/HADOOP-14414.02.patch
|
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  xml  |
| uname | Linux 3d244d828a75 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 6600abb |
| Default Java | 1.8.0_131 |
| unit | https://builds.apache.org/job/PreCommit-HADOOP-Build/12304/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-sls.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/12304/testReport/ |
| modules | C: hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs-httpfs
hadoop-tools/hadoop-sls U: . |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/12304/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Calling maven-site-plugin directly for docs profile is unnecessary
> ------------------------------------------------------------------
>
>                 Key: HADOOP-14414
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14414
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Andras Bokor
>            Assignee: Andras Bokor
>            Priority: Minor
>         Attachments: HADOOP-14414.01.patch, HADOOP-14414.02.patch
>
>
> For a few modules:
> * hadoop-auth
> * hadoop-kms
> * hadoop-hdfs-httpfs
> * hadoop-sls
> we call {{mave-site-plugin}} directly when docs profile is active.
> In main pom we use {{excludeDefaults}} in reporting section and allow only javadoc and
dependency-plugin for the report. Since javadoc plugin is set to {{inherited}} false it won't
be called on individual child modules. So actually {{maven-dependency-plugin:analyze-report}}
is the only additional goal which will run.
> I debugged the process with {{mvn clean package -DskipTests -Dmaven.javadoc.skip=true
-DskipShade -Pdocs -X}} command and in all the 4 affected modules I found the following configuration
for site plugin:
> {code}<reportPlugins>
>     <reportPlugin>
>       <groupId>org.apache.maven.plugins</groupId>
>       <artifactId>maven-dependency-plugin</artifactId>
>       <version>2.10</version>
>       <reportSets>
>         <reportSet>
>           <id>default</id>
>           <reports>
>             <report>analyze-report</report>
>           </reports>
>         </reportSet>
>       </reportSets>
>     </reportPlugin>
>   </reportPlugins>{code}
> At this point I do not see the purpose of calling {{mave-site-plugin}} for docs profile.
It does not contain useful information. Or if it does why don't we call for other modules?
It's inconsistent.
> Considering to remove.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message