hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14400) Fix warnings from spotbugs in hadoop-tools
Date Wed, 10 May 2017 07:19:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004211#comment-16004211
] 

Weiwei Yang commented on HADOOP-14400:
--------------------------------------

I don't think the failed UT is related to this patch, I tried to run the test without the
patch, it failed with the same error. It looks like {{2jobs2min-rumen-jh.json}} is malformed
or something? The error trace is like below

{noformat}
org.apache.hadoop.yarn.exceptions.YarnException: No node! Please configure nodes.
	at org.apache.hadoop.yarn.sls.SLSRunner.startNM(SLSRunner.java:266)
	at org.apache.hadoop.yarn.sls.SLSRunner.start(SLSRunner.java:186)
	at org.apache.hadoop.yarn.sls.SLSRunner.run(SLSRunner.java:845)
	at org.apache.hadoop.yarn.sls.BaseSLSRunnerTest.runSLS(BaseSLSRunnerTest.java:102)
	at org.apache.hadoop.yarn.sls.TestSLSRunner.testSimulatorRunning(TestSLSRunner.java:81)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
{noformat}

Print the stack trace of {{JsonObjectMapperParser#getNext()}}, where seems to return null,
I saw

{noformat}
com.fasterxml.jackson.databind.JsonMappingException: Can not deserialize instance of org.apache.hadoop.tools.rumen.LoggedJob
out of START_ARRAY token
 at [Source: org.apache.hadoop.tools.rumen.PossiblyDecompressedInputStream@1f7e247; line:
1, column: 1]
	at com.fasterxml.jackson.databind.JsonMappingException.from(JsonMappingException.java:256)
	at com.fasterxml.jackson.databind.DeserializationContext.mappingException(DeserializationContext.java:972)
	at com.fasterxml.jackson.databind.DeserializationContext.mappingException(DeserializationContext.java:967)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.deserializeFromArray(BeanDeserializerBase.java:1292)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer._deserializeOther(BeanDeserializer.java:159)
	at com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:135)
	at com.fasterxml.jackson.databind.ObjectMapper._readValue(ObjectMapper.java:3779)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2050)
	at org.apache.hadoop.tools.rumen.JsonObjectMapperParser.getNext(JsonObjectMapperParser.java:79)
	at org.apache.hadoop.yarn.sls.utils.SLSUtils.parseNodesFromRumenTrace(SLSUtils.java:73)
	at org.apache.hadoop.yarn.sls.SLSRunner.startNM(SLSRunner.java:249)
	at org.apache.hadoop.yarn.sls.SLSRunner.start(SLSRunner.java:186)
	at org.apache.hadoop.yarn.sls.SLSRunner.run(SLSRunner.java:845)
	at org.apache.hadoop.yarn.sls.BaseSLSRunnerTest.runSLS(BaseSLSRunnerTest.java:102)
	at org.apache.hadoop.yarn.sls.TestSLSRunner.testSimulatorRunning(TestSLSRunner.java:81)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
{noformat}

Guess we need a jira to track this failure?

> Fix warnings from spotbugs in hadoop-tools
> ------------------------------------------
>
>                 Key: HADOOP-14400
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14400
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>              Labels: findbugs
>         Attachments: HADOOP-14400.001.patch, HADOOP-14400.002.patch
>
>
> Fix 4 warnings in hadoop-tools project since moved to spotbugs.
> # Return value of new org.apache.hadoop.tools.rumen.datatypes.DefaultDataType(String)
ignored, but method has no side effect At MapReduceJobPropertiesParser.java
> # org.apache.hadoop.mapred.gridmix.InputStriper$1.compare(Map$Entry, Map$Entry) incorrectly
handles double value
> # Useless object stored in variable keysToUpdateAsFolder of method org.apache.hadoop.fs.azure.NativeAzureFileSystem.mkdirs(Path,
FsPermission, boolean) At NativeAzureFileSystem.java
> # org.apache.hadoop.yarn.sls.SLSRunner.simulateInfoMap is a mutable collection At SLSRunner.java



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message