hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weiwei Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14400) Fix warnings from spotbugs in hadoop-tools
Date Wed, 10 May 2017 02:48:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003947#comment-16003947
] 

Weiwei Yang commented on HADOOP-14400:
--------------------------------------

Thanks [~ajisakaa] for reviewing this. I agree with all your 3 comments, good catch. I have
addressed them in v2 patch.



> Fix warnings from spotbugs in hadoop-tools
> ------------------------------------------
>
>                 Key: HADOOP-14400
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14400
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>              Labels: findbugs
>         Attachments: HADOOP-14400.001.patch, HADOOP-14400.002.patch
>
>
> Fix 4 warnings in hadoop-tools project since moved to spotbugs.
> # Return value of new org.apache.hadoop.tools.rumen.datatypes.DefaultDataType(String)
ignored, but method has no side effect At MapReduceJobPropertiesParser.java
> # org.apache.hadoop.mapred.gridmix.InputStriper$1.compare(Map$Entry, Map$Entry) incorrectly
handles double value
> # Useless object stored in variable keysToUpdateAsFolder of method org.apache.hadoop.fs.azure.NativeAzureFileSystem.mkdirs(Path,
FsPermission, boolean) At NativeAzureFileSystem.java
> # org.apache.hadoop.yarn.sls.SLSRunner.simulateInfoMap is a mutable collection At SLSRunner.java



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message