hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kai Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14397) Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it
Date Tue, 09 May 2017 10:27:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002442#comment-16002442

Kai Zheng commented on HADOOP-14397:


Should the following from your comments elsewhere be handled here? Thanks!
2. There are only tests for HDFS and local, neither of them perfect. Proposed: move to AbstractContractCreateTest,
test for all filesystems, fix tests and FS where appropriate.
3. Add more tests to generate the failure conditions implied by the updated filesystem spec.
Eg. create over a an existing file, create over a directory, create with negative buffer size,
negative block size, empty dest path, etc, etc. 
This will clarify when precondition checks are made, as well as whether. For example: should
newFSDataOutputStreamBuilder() validate the path immediately?

> Pull up the builder pattern to FileSystem and add AbstractContractCreateTest for it
> -----------------------------------------------------------------------------------
>                 Key: HADOOP-14397
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14397
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: common, fs, hdfs-client
>    Affects Versions: 2.9.0
>            Reporter: Lei (Eddy) Xu
> After reach the stability of the Builder APIs, we should promote the API from {{DistributedFileSystem}}
to {{FileSystem}}, and add necessary contract tests to cover the API for all file systems.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org

View raw message