hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14395) Provide Builder pattern for DistributedFileSystem.append
Date Thu, 25 May 2017 02:32:05 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024086#comment-16024086
] 

Andrew Wang commented on HADOOP-14395:
--------------------------------------

Thanks for working on this Eddy, took a quick look at this one after reviewing the createFileBuilder
subtask. Looks straightforward, some minor comments:

* We'd probably like to rename this one to just {{appendFile}} too
* What's the behavior when both create and append are set on the builder? CreateFlag has this
to say:

{noformat}
 * <li> CREATE|APPEND - to create a file if it does not exist, 
 * else append to an existing file.</li>
{noformat}

Would be good to test to make sure this is true, if we aren't already.

> Provide Builder pattern for DistributedFileSystem.append
> --------------------------------------------------------
>
>                 Key: HADOOP-14395
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14395
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>         Attachments: HADOOP-14395.00.patch, HADOOP-14395.00-trunk.patch
>
>
> Follow HADOOP-14394, it should also provide a {{Builder}} API for {{DistributedFileSystem#append}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message