hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andras Bokor (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HADOOP-14389) Exception handling is incorrect in KerberosName.java
Date Fri, 05 May 2017 12:24:04 GMT
Andras Bokor created HADOOP-14389:
-------------------------------------

             Summary: Exception handling is incorrect in KerberosName.java
                 Key: HADOOP-14389
                 URL: https://issues.apache.org/jira/browse/HADOOP-14389
             Project: Hadoop Common
          Issue Type: Bug
            Reporter: Andras Bokor
            Assignee: Andras Bokor


I found multiple inconsistency:

Rule: {{RULE:\[2:$1/$2\@$3\](.\*)s/.\*/hdfs/}}
Principal: {{nn/host.domain@REALM.TLD}}
Expected exception: {{BadStringFormat: ...3 is out of range...}}
Actual exception: {{ArrayIndexOutOfBoundsException: 3}}
----
Rule: {{RULE:\[:$1/$2\@$0](.\*)s/.\*/hdfs/}} (Missing num of components)
Expected: {{IllegalArgumentException}}
Actual: {{java.lang.NumberFormatException: For input string: ""}}
----
Rule: {{RULE:\[2:$-1/$2\@$3\](.\*)s/.\*/hdfs/}}
Expected {{BadStringFormat: -1 is outside of valid range...}}
Actual: {{java.lang.NumberFormatException: For input string: ""}}
----
Rule: {{RULE:\[2:$one/$2\@$3\](.\*)s/.\*/hdfs/}}
Expected {{java.lang.NumberFormatException: For input string: "one"}}
Acutal {{java.lang.NumberFormatException: For input string: ""}}
----

In addtion:
{code}[^\\]]{code}
does not really make sense in {{ruleParser}}. Most probably it was needed because we parse
the whole rule string and remove the parsed rule from beginning of the string: {{KerberosName#parseRules}}.
This made the regex engine parse wrong without it.

In addition:
In tests some corner cases are not covered.





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message