hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-14386) Make trunk work with Guava 11.0.2 again
Date Mon, 08 May 2017 04:54:04 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-14386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrew Wang updated HADOOP-14386:
---------------------------------
    Attachment: HADOOP-14386.003.patch

Thanks for the confirmation [~ozawa]. New patch fixes the checkstyle and also rewinds the
Guava version to 11.0.2. I think this is ready for review.

I could use a closer look at the YARN changes:

* WebApp#getPrefix trims leading whitespace from the route. It looks like the routes are set
up by internal code (e.g. AM, RM) so I don't know why we'd want to trim leading spaces. Anyway,
seems unlikely that handling unicode spaces is important for this, and it's also not a public
API.
* ApplicationSubmissionContextPBImpl validates that the tags are ASCII. Since these tags are
meant to be displayed, I don't think it makes sense for them to be non-printable control characters.
Thus this is incompatible, but it seems like a good change.

These are both easy to undo if we want to be more conservative. LMK.

> Make trunk work with Guava 11.0.2 again
> ---------------------------------------
>
>                 Key: HADOOP-14386
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14386
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: HADOOP-14386.001.patch, HADOOP-14386.002.patch, HADOOP-14386.003.patch
>
>
> As an alternative to reverting or shading HADOOP-10101 (the upgrade of Guava from 11.0.2
to 21.0), HADOOP-14380 makes the Guava version configurable. However, it still doesn't compile
with Guava 11.0.2, since HADOOP-10101 chose to use the moved Guava classes rather than replacing
them with alternatives.
> This JIRA aims to make Hadoop compatible with Guava 11.0.2 as well as 21.0 by replacing
usage of these moved Guava classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message