hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14384) Reduce the visibility of {{FileSystem#newFSDataOutputStreamBuilder}} before the API becomes stable
Date Fri, 05 May 2017 19:26:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998829#comment-15998829
] 

Andrew Wang commented on HADOOP-14384:
--------------------------------------

Hi Anu,

Please do not refer to anyone's code as "badly executed", particularly that of a new contributor.
This isn't how we grow the community, and this API went through review by myself and Stack,
among others.

Let's try and focus on the positives. Steve phrased his feedback as making a few changes,
not a rework. And, as I think everyone agrees, the idea of a create builder is good. Since
these changes affect compatibility we want to get the details right, but the patch and the
idea are still largely good.

Thanks,
Andrew

> Reduce the visibility of {{FileSystem#newFSDataOutputStreamBuilder}} before the API becomes
stable
> --------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14384
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14384
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.9.0
>            Reporter: Lei (Eddy) Xu
>            Assignee: Lei (Eddy) Xu
>            Priority: Minor
>         Attachments: HADOOP-14384.00.patch, HADOOP-14384.01.patch
>
>
> Before {{HADOOP-14365}} finishes, we should limit the this API within Hadoop project
to prevent it being used by end users or other projects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message