hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14434) Use MoveFileEx to allow renaming a file when the destination exists
Date Wed, 17 May 2017 23:19:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014921#comment-16014921
] 

Chris Douglas commented on HADOOP-14434:
----------------------------------------

Sorry [~lukmajercak], I missed your [comment |https://issues.apache.org/jira/browse/HADOOP-14434?focusedCommentId=15987846&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15987846]

The change to {{TestRollingUpgrade}} looked like leftover debugging, since it just added a
timeout to the test. What's going on, there?

> Use MoveFileEx to allow renaming a file when the destination exists
> -------------------------------------------------------------------
>
>                 Key: HADOOP-14434
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14434
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.7.1, 2.7.3, 3.0.0-alpha1, 3.0.0-alpha2
>            Reporter: Lukas Majercak
>            Assignee: Lukas Majercak
>              Labels: windows
>         Attachments: HADOOP-14434.002.patch, HDFS-11713.001.patch
>
>
> The {{NativeIO.c#renameTo0}} currently uses {{MoveFile}} Windows system call, which fails
when renaming a file to a destination that already exists.
> This makes the {{TestRollingUpgrade.testRollback}} test fail on Windows, as during that
execution, a DataNode tries to rename block's meta file to a destination that exists.
> The proposal is to change to using {{MoveFileEx}} Windows call, and passing in {{MOVEFILE_REPLACE_EXISTING}}
flag to force the renaming.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message