hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-14233) Delay construction of PreCondition.check failure message in Configuration#set
Date Mon, 01 May 2017 23:03:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991715#comment-15991715
] 

Andrew Wang commented on HADOOP-14233:
--------------------------------------

I don't think it's worth having a revert-and-reapply policy, my comment was for people who
are also doing grepping on git log. A revert-and-reapply policy won't work unless there's
someone or something enforcing this. My (forlorn) hope is that one day we'll solve this by
using Gerrit to automate the commit and have a precommit check on the commit message.

FWIW I maintain a list of commits->JIRAs fixups for my versions script here, which is what
prompted this comment: https://github.com/umbrant/versions/blob/master/metadata/3.0.0-alpha3.yaml

> Delay construction of PreCondition.check failure message in Configuration#set
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-14233
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14233
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>             Fix For: 2.9.0, 2.8.1, 3.0.0-alpha3
>
>         Attachments: HADOOP-14233.1.patch
>
>
> The String in the precondition check is constructed prior to failure detection. Since
the normal case is no error, we can gain performance by delaying the construction of the string
until the failure is detected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message