hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HADOOP-14233) Delay construction of PreCondition.check failure message in Configuration#set
Date Thu, 04 May 2017 11:08:04 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-14233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996552#comment-15996552
] 

Steve Loughran edited comment on HADOOP-14233 at 5/4/17 11:07 AM:
------------------------------------------------------------------

BTW, this is causing problems linking against old guava versions; the relevant method in Guava
is 20.0+; any app with an older guava version on their CP is going to see a stack trace here.

I'm wondering if, short term, I can change it to do the check/string construct ourselves



was (Author: stevel@apache.org):
BTW, this is causing problems linking against old guava versions; the relevant method in Guava
is 20.0+; any app with an older guava version on their CP is going to see a stack trace here.


> Delay construction of PreCondition.check failure message in Configuration#set
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-14233
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14233
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>             Fix For: 2.9.0, 2.8.1, 3.0.0-alpha3
>
>         Attachments: HADOOP-14233.1.patch
>
>
> The String in the precondition check is constructed prior to failure detection. Since
the normal case is no error, we can gain performance by delaying the construction of the string
until the failure is detected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org


Mime
View raw message